Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478613 --- Comment #2 from Jim Radford <radf...@blackbean.org> 2009-03-14 10:42:49 EDT --- (In reply to comment #1) > - If packaging Emacs modes, you might want to consider making a separate > subpackage that depends on emacs. See for instance how I handle it for vala: > http://cvs.fedoraproject.org/viewvc/devel/vala/vala.spec?revision=1.36 I think this is overkill for small files (like .el files). Plus, I can't picture wanting emacs installed because I installed ledger. > - chmod -x scripts/* should probably be done in %setup, not %build. It's not > really part of the build process Moved. > C++'s <cstr> and <string.h> functions now return a const char * if the input > is const char *, and a char * if the input is char *. Patched. > - You modified the .texi file, but do not BuildRequire: texinfo, so the > documentation is not regenerated Fixed. Thanks for your comments. Spec URL: http://blackbean.org/review/ledger.spec SRPM URL: http://blackbean.org/review/ledger-2.6.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
