Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474992





--- Comment #13 from Jan ONDREJ <ondr...@salstar.sk>  2009-04-02 02:33:58 EDT 
---
(In reply to comment #12)
> Sorry for taking so long;

No problem. We have time. I also forgot that I have an open review. :)

> However, it's kind of weird to patch up to a CVS snapshot by including a patch
> thats larger than the source tarball.  It's OK to pick patches out of the
> upstream SCM if that's what you want, but if you want to ship a snapshot, it's
> better to simply do a checkout and include that as your tarball.  See
> http://fedoraproject.org/wiki/Packaging/SourceURL for information on how we do
> this.  Basically, you make the tarball but include instructions for generating
> it so that someone else who comes along will know where it came from. 
> Currently you just have this big patch with no information on duplicating it. 
>  

OK, repackaged as source and also sent an email to upstream mailinglist, which
is asking to release this as stable (or at least official snapshot).

New package can be found here:
  http://www.salstar.sk/pub/fedora/SPECS/libirman.spec
 
http://www.salstar.sk/pub/fedora/SRPMS/10/libirman-0.4.4-5.20090314cvs.fc10.src.rpm

It was also possible to strip patch by removing "configure" part, which is
autoregenerated later from spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to