Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498246 --- Comment #1 from Fabien Georget <fabien.geor...@gmail.com> 2009-04-29 15:46:26 EDT --- It's only 'pre-review' since I can't be a sponsor. - You package doesn't build. It seems that a BuildRequire is missing (I suppose openmpi-devel ) - Instead of using command for adding shebang, you should better use a patch in the spec, and give it at upstream ! - I think that "%doc license.gpl Examples/" is not a good thing. Because Examples/ contains some executable. Install it with the doc flags modify the rights. - In the file /usr/share/towhee/Forcefields, you remove Makefile but not Makefile.am and Makefile.in - Some macros are available in rpm like %{_cat}, %{_cp} ... for coherence you should consider to use them. - Extract from guidelines " Use %global instead of %define, unless you really need only locally defined submacros within other macro definitions (a very rare case)." -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
