Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=426753 Jens Petersen <peter...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(peter...@redhat.c | |om) | --- Comment #44 from Jens Petersen <peter...@redhat.com> 2009-05-04 00:03:40 EDT --- (In reply to comment #43) > New update Thanks! > 1) carries around a ppc workaround that really should go in macros.ghc Yeah we could add something in the macros to help with this, but it is a bit tedious: I hope we can fix the real problem on ppc soon. > 2) only builds on fedora 12 (yay?) I hope to backport latest ghc to f11 soon. We might have to wait for a new gtk2hs release. > 3) converts the value added default config into a patch directly against the > upstream source. what this patch does is replaces the xmonad line of the > default verbose config with an expansion that loads xterm with the man page > showing. in the future, i'll probably add a comment to the user Good idea. I think better to rename the patch to xmonad-config-show-manpage.patch or something like that. > 4) includes just xmonad-start without doing xmonad-session. Good - I think the name in the .desktop file should just be "xmonad" or "XMonad" though not "xmonad-start". > 5) renumbers the source to make more sense > 6) includes other changes proposed here Ok Otherwise looks pretty good to me now. I am going to take it for a spin and then do the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review