Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: filelight-1.0 - cool diskspace use browser for kde https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205023 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-09-05 06:08 EST ------- {Not official reviewer} + Mockbuild is successfull for i386 FC6 with messages No translations found for filelight in /var/tmp/filelight-1.0-1-root don't use %files -f %{name}.lang use only %files in SPEC file - rpmlint on SOURCE rpm is NOT silent I: filelight checking W: filelight hardcoded-packager-tag Dag The Packager tag is hardcoded in your spec file. It should be removed, so as to use rebuilder's own defaults. => Remove packager tag W: filelight setup-not-quiet You should use -q to have a quiet extraction of the source tarball, as this generate useless lines of log ( for buildbot, for example ) packaging looks ok. => use setup -q instead of setup only You need to replace %prep section to %prep %setup -q -n %{name}-%{version} + dist tag is NOT present - Buildroot is Must be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + source URL is correct + BR is correct + License used is GPL + License file COPYING is included - Desktop files are NOT handled correctly. Check http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 + MD5 sum on tarball is matching upstream tarball aa885e53e09f40e7fdd371395140b957 filelight-1.0.tar.bz2 - rpmlint on Binary RPM is NOT silent E: filelight file-in-usr-marked-as-conffile /usr/share/config/filelightrc A file in /usr is marked as being a configuration file. Store your conf files in /etc/ instead. W: filelight conffile-without-noreplace-flag /usr/share/config/filelightrc A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here Follow comment #1 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
