Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498189 --- Comment #3 from Chris Weyl <cw...@alumni.drew.edu> 2009-05-04 11:38:37 EDT --- We need a br on Test::Pod; and the third word from the end of the second line of %description should probably be "without", not "which" :) The XS.so in the requires should be filtered, as it's a privat plugin library for Perl that isn't in the system lib paths. A construct like the following, inserted before %description, will do the trick. (see, e.g. perl-CSS-Minifier-XS) # don't "provide" private Perl libs %global _use_internal_dependency_generator 0 %global __deploop() while read FILE; do /usr/lib/rpm/rpmdeps -%{1} ${FILE}; done | /bin/sort -u %global __find_provides /bin/sh -c "%{__grep} -v '%{perl_vendorarch}/.*\\.so$' | %{__deploop P}" %global __find_requires /bin/sh -c "%{__deploop R}" Please add the BR and *.so filtering. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1335368 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz.srpm Final provides / requires will be sane, once XS.so has been removed from the provides: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm perl(JavaScript::Minifier::XS) = 0.05 perl-JavaScript-Minifier-XS = 0.05-1.fc12 perl-JavaScript-Minifier-XS(ppc-32) = 0.05-1.fc12 XS.so ====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) perl >= 0:5.006 perl(DynaLoader) perl(Exporter) perl(:MODULE_COMPAT_5.10.0) perl(strict) perl(warnings) rtld(GNU_HASH) =====> perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm ====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm perl(JavaScript::Minifier) perl(Module::Build) perl(Test::More) =====> perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm <===== ====> rpmlint perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This package provides debug information for package perl-JavaScript-Minifier-XS. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm perl-JavaScript-Minifier-XS-debuginfo = 0.05-1.fc12 perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-1.fc12 ====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
