Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499316 Parag AN(पराग) <panem...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panem...@gmail.com AssignedTo|nob...@fedoraproject.org |panem...@gmail.com Flag| |fedora-review+ --- Comment #2 from Parag AN(पराग) <panem...@gmail.com> 2009-05-06 04:37:51 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1338073 + rpmlint is silent for SRPM and for RPM. + source files match upstream url cf683c623b12342a951f541c9e674cd162a9ad91 meterbridge-0.9.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package meterbridge-0.9.2-3.fc12.i586 => Requires: libSDL-1.2.so.0 libSDL_image-1.2.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libjack.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libm.so.6(GLIBC_2.1) libpthread.so.0 librt.so.1 rtld(GNU_HASH) Provides: meterbridge = 0.9.2-3.fc10 + Not a GUI application suggestions: 1) should ask upstream to add contents to README. 2) License tag should be GPLv2+ APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
