Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497035 Christian Krause <c...@plauener.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Christian Krause <c...@plauener.de> 2009-05-06 17:57:16 EDT --- (In reply to comment #3) > (In reply to comment #2) > > * Patch0: TODO > > - it is recommended to send the patches upstream and add a short comment > > in the spec file about the status of the bug report > > > > I sent them the patch and the desktop file I'm using via email since they > don't > have a bugtracker. Ok, thanks! > > * Compilation: TODO > > - mock build works > > - package builds correctly in koji for F12, F11 and F10 > > - auto* tools adds additionally "-O2" (via acinclude.m4) - this is not a > > problem right now, but probably if Fedora changes once its default > > optimization > > flags then the package would be compiled with "-O2 -O3" or something like > > this > > (I don't consider this as a big issue, but if it could be solved easily, > > then > > it should be fixed IMHO) > > > > -O2 comes before %optflags during compilation, and the last one wins. Hence it > won't affect any effect even if our %optflags start using -O3. > > I can still change it but do you think it's worth? (I will need to BR autohell > since I will have to change the timestamp of the m4 file) Yes, I agree with your conclusion and that since there isn't a real problem here it is not worth to re-build all autotools-generated files including configure. > > * packages must own all directories: TODO > > - in general OK > > - just a very minor suggestion: %{_datadir}/apps/%{name} should better be > > %{_datadir}/apps/%{name}/ (just to indicate that really a directory and not > > a > > file gets packaged) > > > > Thanks for pointing this out. I usually do it the way you told but apparently > I > missed it this time. Ok. > > * functional test: TODO > > - program starts and can be used > > - however, when I press "play", I get an message box "Error:" (the sound > > settings are not touched, all channels are set to "alsa_pcm:capture_1/2" or > > "alsa_pcm:playback_1/2" ) - I'm not sure whether there is any need to > > configure any jack-related settings in my system... > > You will need to have a running jackd before you use creox (many jack > applications don't start jackd by themselves automatically). > > I recommend using qjackctl for starting/configuring jack and controlling jack > ports. Also if you didn't do it already, check the file > /usr/share/doc/jack-audio-connection-kit-*/README.Fedora > for setting up your jack configuration before you start it up. It's worth it. After I setup jackd, the error did not happen anymore. Since I don't have the needed equipment, I could not do a complete functionality test. > Spec URL: http://oget.fedorapeople.org/review/creox.spec > SRPM URL: http://oget.fedorapeople.org/review/creox-0.2.2-0.2.rc2.fc10.src.rpm The new package looks good, all issues were addressed. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review