Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499979





--- Comment #2 from Erik van Pienbroek <erik-fed...@vanpienbroek.nl>  
2009-05-22 09:01:57 EDT ---
(In reply to comment #1)
> + Package follows the Fedora MinGW packaging guidelines
>   version seems to be slightly ahead of native (1.1 vs. 1.0) please try to
>   stick to the native version

Yeah I know, but there was a message on the fedora-mingw mailing list recently
that we were advised to upgrade to version 1.1 as it contains several win32
optimalisations:
http://lists.fedoraproject.org/pipermail/fedora-mingw/2009-May/001355.html

> ! use %global instead of %define  

A lot of MinGW packages we have use these %define's. I think we should check
every MinGW package which is in Fedora now and fix the packages if necessary.

For this package I've replaced the %define's with %global's:

Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2.spec
SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2-1.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to