Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502856 Jochen Schmitt <joc...@herr-schmitt.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |joc...@herr-schmitt.de AssignedTo|nob...@fedoraproject.org |joc...@herr-schmitt.de Flag| |fedora-review? --- Comment #1 from Jochen Schmitt <joc...@herr-schmitt.de> 2009-05-27 13:58:40 EDT --- Good: + Basename of the SPEC file matches with package name + Package name fullfill with naming guidelines + URL tag shows on proper project homepage + Package contains most recent release of the application + Could download upstream sources via spectool -g + Package sources matches with upstream (md5sum: 0ede5640b1c6f0f2f513e992b60a261f) + Package contains valid License tag + License tags excalim GPLV3+ as an valid OSS license + Package contains verbatin copy of the license text + Consistently rpm macro usage + Package doesn't contains subpackages + Proper Buildroot defintion + Buildroot will be cleaned on beginning of %clean and %install + RPM_OPT_FLAGS will be honour on build step + Build step support smp enabled make + Local build works fine + No complaints from rpmlint for source rpm + No complaints from rpmlint for binary rpm + No complaints from rpmlint for debuginfo rpm + Debuginfo package contains sources + Local install/uninstall works fine + Short test of the application looks fine. + Files has proper files permissions + All package files are owned by the package + %files stanza contains no duplicated entries + %doc stanzs is small, so we don't need an extra subpackage + Package contains proper Changelog Bad: - Source header indicates GPLv3 as license instead of GPLv3+ Please talk with upstream for clarification - Scratch build failed on koji Please see: http://koji.fedoraproject.org/koji/taskinfo?taskID=1380090 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
