Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502979 --- Comment #1 from Jussi Lehtola <jussi.leht...@iki.fi> 2009-05-28 04:06:33 EDT --- A few initial notes: - You're mixing URL with Source0. Source0 should have the contents of the current URL, URL should be http://ophcrack.sourceforge.net/ instead. - I think you need BR: expat-devel. No need to specify the Requires: though, these will be picked up by RPM. - Remove the extra >>'s from the description. - Instead of Icon=ophcrack.png use Icon=ophcrack in the desktop file. - You are mixing %{buildroot} and $RPM_BUILD_ROOT, this is not allowed. Choose one and stick with it. - Drop %{_datadir}/applications as this is a standard system directory. Besides, now you're owning %{_datadir}/applications/%{name}.desktop twice as owning %{_datadir}/applications owns everything in it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
