Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034





--- Comment #24 from Bastien Nocera <bnoc...@redhat.com>  2009-06-10 10:54:46 
EDT ---
(In reply to comment #22)
> I also noticed that there is one occurrence of rm that should be converted to
> %{__rm} for macro consistency.  

Done

(In reply to comment #7)
> I did a full review on this package. Everything seems fine except
> 
> * docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc

Done

> * the examples directory should be included in devel's %doc

Done

> Other than these two things the package yields Fedora Guidelines.
> 
> A question: Isn't it time to rename this package as libmusicbrainz2 and call
> libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is 
> not
> done yet?  

This would be a pretty pointless shuffling of package names.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to