Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505184 --- Comment #13 from Jussi Lehtola <jussi.leht...@iki.fi> 2009-06-13 05:56:47 EDT --- rpmlint output: xorriso.x86_64: W: incoherent-version-in-changelog 0.3.8-4 ['0.3.8-4.pl00.fc11', '0.3.8-4.pl00'] 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Add the missing patchlevel suffix to the last item in the changelog. - Also, you might want to use install -D -p -m 644 %{SOURCE1} %{buildroot}/%{_datadir}/kde4/services/ServiceMenus/xorriso_servicemenu.desktop instead of mkdir -p %{buildroot}/%{_datadir}/kde4/services/ServiceMenus cp -p %{SOURCE1} %{buildroot}/%{_datadir}/kde4/services/ServiceMenus MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. ~OK - The MIT bit is still missing, but I guess that's okay. - In fact, when you think of it, the resulting license of the whole shebang is GPLv2, since it's compatible with every one of the licenses in the package, so you were right from the start :) MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. NEEDSWORK - You are missing ownership of servicemenu dir as stated in #12. MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. ??? - Must check this. MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
