Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490 Michal Ingeli <m...@v3.sk> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Michal Ingeli <m...@v3.sk> 2009-07-13 11:22:22 EDT --- (In reply to comment #8) > (In reply to comment #7) > > Looks fine, just few more things. > > - package must own %{geminstdir} > > "file /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4 is not owned by any > > package" "%{geminstdir}" must be listed as "%dir %{geminstdir}", because listing directory works recursively. So now you can see a lot of twice listed files in build.log. I am approving this package, but you should fix this before import. > > - put examples into %doc OK > Thank you for the advice. I've made the necessary changes, updated files are > as > follows: > > Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec > Updated SRPM: > http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-4.fc11.src.rpm > Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1471250 One more advice, look at [1] and replace %define with %global. APPROVED [1] https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
