Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: twinkle - A SIP Soft Phone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206989 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-09-19 01:23 EST ------- {Not Official Reviewer} packaging looks ok. + Mockbuild is successfull for i386 FC6 with some warnings + rpmlint on binary rpm is silent + dist tag is present + Buildroot is correct + source URL is correct + BR is correct + License used is GPL + License file COPYING is included + desktop file is handled correctly + MD5 sum on tarball is matching upstream tarball 245ffd3b4a6f968d8f80d42f6aad079c twinkle-0.8.1.tar.gz + No duplicate files You can use --delete-original with desktop-install-file Instead of writing rm -f ${RPM_BUILD_ROOT}%{_datadir}/applications/twinkle.desktop desktop-file-install --vendor fedora \ --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \ --add-category X-Fedora \ twinkle.desktop you can write only in SPEC desktop-file-install --vendor fedora \ --delete-original --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \ --add-category X-Fedora \ twinkle.desktop Unable to install on FC6 got error: Failed dependencies: libresolv.so.2(GLIBC_PRIVATE) is needed by twinkle-0.8.1-1.fc6.i386 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
