Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543685 --- Comment #2 from Doug Ledford <dledf...@redhat.com> 2009-12-05 10:14:37 EDT --- (In reply to comment #1) > > %makeinstall > > Avoid this macro unless normal "make DESTDIR=${RPM_BUILD_ROOT} install" > (with > an optional INSTALL="install -p" doesn't work. Add a comment if you really > need > this macro. The way %makeinstall overrides variables to insert the buildroot > path bears risks and has lead to problems before. Fixed. > > %{_sysconfdir}/libibverbs.d/*.driver > > "repoquery --whatprovides /etc/libibverbs.d" on Fedora 12 returns nothing, > which means it's an unowned directory. Most likely in package "libibverbs". New version of libibverbs being built that now owns this directory. > > %package static > > Summary: Static version of the libnes driver > > Group: System Environment/Libraries > > Rather "Development/Libraries". Fixed. > > Provides: %{name}-devel = %{version}-%{release} > ... > > %files static > > %defattr(-,root,root,-) > > %{_libdir}/*.a > > A static library without any headers? Isn't this package missing a dependency > on some -devel package that would define the API for this lib? Same question > applies to the virtual -devel package. Yes and no. Even if a user application directly links this file into their code, they wouldn't ever be calling it and wouldn't need any API information. This static library only serves a purpose when the user is also statically linking libibverbs into their application (in which case presumably they have the libibverbs-devel package already installed, which is the yes part of the answer), however even then, this library is actually only linked against libibverbs while the user code is also only linked against libibverbs, and since the libibverbs static library is already compiled just as this is, there really isn't any requirement for headers to define the API during the link process. So yes in the sense that the user space code probably needs the libibverbs headers before this is useful, but no in the sense that this library itself doesn't have any requirements as it's only going to be linked against other object code. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
