Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530021 --- Comment #27 from Matthias Saou <matth...@rpmforge.net> 2009-12-10 05:06:53 EDT --- I'll look into becoming your sponsor if needed. For now, a few comments about the moovida.spec file : * You should remove the first line (the python dir comment) * You're mixing $RPM_BUILD_ROOT and %{buildroot} when you shouldn't * You're inconsistently skipping one or two lines between sections * Putting all (build)requirements on a single line makes them hard to read... I personally prefer putting one per line (or a few more if they're related), not going over 80 columns and keeping the same order for requirements and buildrequirements. * The plain explicit "python" requirement is clearly not needed * The "%doc COPYING LICENSE*" line should be below the %defattr for consistency * Why are some files being forced to mode 755? If there is a reason, you should add a comment above, because doing that is at least partly wrong since they end up listed twice, possibly with different modes (and this might be an undefined behaviour, though it's certainly the last one who wins). The proper fix here if those files never need to be executed directly might be to remove the "#!" line instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
