Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543159 Thomas Spura <toms...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |toms...@fedoraproject.org AssignedTo|nob...@fedoraproject.org |toms...@fedoraproject.org Flag| |fedora-review? --- Comment #1 from Thomas Spura <toms...@fedoraproject.org> 2009-12-25 13:53:04 EDT --- Review: Good: - name ok - latest version packaged - correctly installing *.mo - no *.la - no libs - %files ok - %doc ok - group ok - %install ok - rpmlint clean Needswork: - BR/R not complete: to own the folder %{_datadir}/dbus-1/services: Requires: dbus is missing - License is wrong: In COPYRIGHT is mentioned that zeitgeist/loggers/iso_strptime.py is stolen and under license LGPLv3 only Rest of the *.py headers say LGPLv3+ -> Correctly license is LGPLv3+ and LGPLv3 Please mention, that zeitgeist/loggers/iso_strptime.py is LGPLv3 and the rest LGPLv3+ in the specfile as a comment. see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
