Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|188267 |188268 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-11-09 13:59 EST ------- Miroslav, whether you will implement the comment #9 I'd leave on your decision. Other nits: As you require /usr/sbin/sendmail you should probably also BuildRequire it because otherwise the /usr/lib/sendmail default from the configure script will be used. The snmpwalk non-requirement looks to me like a non issue because user running the arpfetch command will get a message snmpwalk not found if it is not there. And I wouldn't say that the script is non functional, it just requires installation of another package. This is really only issue of aesthetics and I'd like to leave that on Miroslav to decide. The release number should be probably just a single number (+ disttag) for FC devel. The scripts aren't one-to-one copy of the scriptlets from guidelines but I don't think it is mandatory to have one-to-one copy if they work the same. As the things above are only minor nits and comments and the package is OK otherwise I think I can call it ACCEPTED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
