Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: solfege - music education software https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219653 ------- Additional Comments From [EMAIL PROTECTED] 2006-12-20 13:33 EST ------- Well, * Use rpmlint - For src.rpm: ----------------------------------------------------- W: solfege macro-in-%changelog _libexecdir ----------------------------------------------------- rpmbuild tries to expand the macro in %changelog and this should be avoilded. In %changelog, when you want to use percent, please use %%, i.e. ----------------------------------------------------- - Move original binary to %%{_libexecdir} ----------------------------------------------------- * Desktop files ----------------------------------------------------- Categories=GNOME;Application;AudioVideo;Audio;Education; ----------------------------------------------------- - Well, category "Application" is also deprecated and this should be removed. You can use: ----------------------------------------------------- desktop-file-install --vendor fedora --delete-original \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ --remove-category Application \ $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop ----------------------------------------------------- * Documentation ----------------------------------------------------- iconv -o $RPM_BUILD_DIR/%{name}-%{version}/AUTHORS -f ISO-8859-15 -t UTF-8 $RPM_BUILD_DIR/%{name}-%{version}/AUTHORS iconv -o $RPM_BUILD_DIR/%{name}-%{version}/README -f ISO-8859-15 -t UTF-8 $RPM_BUILD_DIR/%{name}-%{version}/README ----------------------------------------------------- - Well, actually these remove AUTHORS and README. In fact rpmlint complaints as following. ----------------------------------------------------- E: solfege zero-length /usr/share/doc/solfege-3.6.4/AUTHORS E: solfege zero-length /usr/share/doc/solfege-3.6.4/README ----------------------------------------------------- And, $RPM_BUILD_DIR/%{name}-%{version} is not needed because the working directory at this stage is there. Usually: ----------------------------------------------------- for f in AUTHORS README ; do iconv -f ISO-8859-15 -t UTF-8 $f > ${f}.tmp && \ %{__mv} -f ${f}.tmp ${f} || \ %{__rm} -f ${f}.tmp done ----------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
