Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: system-switch-java - Java toolset switcher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223627





------- Additional Comments From [EMAIL PROTECTED]  2007-01-23 19:00 EST -------
I do not want to sound picky, but
- the URL included in the spec is not very useful.
- The purpose of the md5sum check is to guarantee that the file included in the
src.rpm coincides with the one from the upstream source. Computing the md5sum by
the packager and by the reviewer based on the SAME file extracted from the same
src.rpm guarantees nothing.
- each modification to the spec should be reflected in the release tag and in
the changelog

In this special case, I suggest including a comment in the spec, specifying that
there is no other upstream but the src.rpm and, also, defining a real path for
the said src.rpm (hosting it for instance on http://fitzsim.org or on
people.redhat.com)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to