Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: statserial https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-02-09 07:23 EST ------- Formal review for release 39: MUST - package meets naming guidelines - package meets packaging guidelines - license ( GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, sha1sum 3ace36585c82238003b37f267263f06aad4f0afd statserial-1.1.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/folders - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no static, .la, .pc files - rpmlint is silent on src.rpm; for the binary the following warnings are generated: W: statserial spurious-executable-perm /usr/share/doc/statserial-1.1/phone_log W: statserial doc-file-dependency /usr/share/doc/statserial-1.1/phone_log /bin/bash Since phone_log IS a bash script and bash is supposed to be already installed anyway, no additional packages are actually pulled so I guess both warnings can safely be ignored. SHOULD - Builds fine in mock for FC6 and devel (x86_64) - Runs as advertised on FC6/x86_64 Notes: I have no access to 390 so I can only assume that the hardware being different, the ExcludeArch is justified. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
