Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: php-pear Alias: php-pear https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226295 ------- Additional Comments From [EMAIL PROTECTED] 2007-02-21 14:44 EST ------- ==== REVIEW CHECKLIST ==== W: php-pear invalid-license The PHP License v3.0 W: php-pear invalid-license The PHP License v3.0 Trivial fix. W: php-pear conffile-without-noreplace-flag /etc/rpm/macros.pear okay. W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.__uri W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.__uri W: php-pear hidden-file-or-dir /usr/share/pear/.depdblock E: php-pear zero-length /usr/share/pear/.depdblock W: php-pear hidden-file-or-dir /usr/share/pear/.depdb W: php-pear hidden-file-or-dir /usr/share/pear/.lock E: php-pear zero-length /usr/share/pear/.lock W: php-pear hidden-file-or-dir /usr/share/pear/.filemap W: php-pear hidden-file-or-dir /usr/share/pear/.channels W: php-pear hidden-file-or-dir /usr/share/pear/.channels W: php-pear hidden-file-or-dir /usr/share/pear/.pkgxml W: php-pear hidden-file-or-dir /usr/share/pear/.pkgxml W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.pecl.php.net W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.pecl.php.net W: php-pear hidden-file-or-dir /usr/share/pear/.channels/.alias W: php-pear hidden-file-or-dir /usr/share/pear/.channels/.alias E: php-pear zero-length /usr/share/pear/test/Structures_Graph/tests/README W: php-pear hidden-file-or-dir /usr/share/pear/.registry W: php-pear hidden-file-or-dir /usr/share/pear/.registry these are okay E: php-pear non-executable-script /usr/share/pear/test/Structures_Graph/tests/all-tests.php 0644 E: php-pear non-executable-script /usr/share/pear/doc/Structures_Graph/docs/generate.sh 0644 E: php-pear non-executable-script /usr/share/pear/data/Structures_Graph/genpackage.xml.pl 0644 E: php-pear non-executable-script /usr/share/pear/data/Structures_Graph/publish.sh 0644 E: php-pear non-executable-script /usr/share/pear/data/Structures_Graph/package.sh 0644 Trivial fix W: php-pear setup-not-quiet okay E: php-pear use-of-RPM_SOURCE_DIR Trivial fix W: php-pear no-%build-section Must fix. Trivial - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec file legible - sources match upstream d7ec831fe6439fae783b56bd8499ee17 install-pear-nozlib.phar - package successfully compiles and builds on FC-6 x86_64 - all build depenedencies listed in BR - no locales - no shared library files - not relocatable - package owns all directories it creates - directories it does not created owned by filesystem or rpm - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no libraries with suffixes - no devel subpackage requried - no libtool archives - not a GUI app - package does not own files or directories owned by other packages ==== MUST FIX ==== - MUST add empty %build section. I simply cannot approve this with a straight face when every single other pear package is requried to have this. Either we go through all the trouble to fix the pear template, or you simply add an empty %build. - Fix non-executable-script rpmlint warnings - Change Source0 to: http://pear.php.net/install-pear-nozlib.phar or else add this URL in a comment above Source0 ==== SHOULD FIX ==== - Change license tag to "PHP License" or "PHP Licnese 3.0" - Remove RPM_SOURCE_DIR from spec file. This is a community project, not a Joe Orton project, and consistent thinking is the hobgoblin of a feeble mind (or something like that). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
