Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: diffstat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225695


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[EMAIL PROTECTED]    |[EMAIL PROTECTED]
               Flag|                            |fedora-review?




------- Additional Comments From [EMAIL PROTECTED]  2007-03-03 20:25 EST -------
Needs work:
* Source 0 is not available
(ftp://invisible-island.net/diffstat/diffstat-1.43.tar.gz)
* BuildRoot should be 
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires: gzip and bzip2 should not be included (exceptions)
* Missing SMP flags. If it doesn't build with it, please add a comment
* The %makeinstall macro should not be used
* deffattr should be (-,root,root,-) instead of (-,root,root)
* rpmlint output:

Source RPM:
W: diffstat summary-ended-with-dot A utility which provides statistics based on
the output of diff.
W: diffstat invalid-license distributable
W: diffstat macro-in-%changelog configure

rpmlint of diffstat:
W: diffstat summary-ended-with-dot A utility which provides statistics based on
the output of diff.
W: diffstat invalid-license distributable

rpmlint of diffstat-debuginfo:
W: diffstat-debuginfo invalid-license distributable

Is there a text of license somewhere?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to