Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: scim-anthy https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226390 ------- Additional Comments From [EMAIL PROTECTED] 2007-03-12 07:43 EST ------- Thank you for reviewing. (In reply to comment #1) > Created an attachment (id=149671) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149671&action=view) [edit] > mock build log of scim-anthy-1.2.2-1 on FC-devel i386 > > Merge review for scim-anthy 1.2.2-1 > > * URL > Umm.. Is http://scim-imengine.sourceforge.jp/ hijached?? Seems like that. > * Source URL > - Source URL must be where we can directly download the source > by "wget -N", for example. > Currently Source0 points to only a HTML. Fixed. > * Rebuild > - Mock build fails (on FC-devel i386). > * Note: making autoconf called after configure is done must > be avoided. Added autoconf to BR and invoked it before %%configure. it should works. > * rpmlint > A. For srpm: > ---------------------------------------------------- > A-1 W: scim-anthy mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 5) > ---------------------------------------------------- > A-1 Minor issue, however, it is recommended to fix this. Fixed. > B. For binary rpm > ---------------------------------------------------- > B-1 E: scim-anthy obsolete-not-provided iiimf-le-canna > B-2 E: scim-anthy zero-length /usr/share/doc/scim-anthy-1.2.2/TODO > ---------------------------------------------------- > B-1 _should_ be ignored IMO, because scim-anthy does not > actually provide iiimf Agreed. and it was actually intentional stuff. > B-2 would you explain why you want to include this empty file? Assuming that it was not an empty file before, and becomes empty after that. Removed. > * Directory ownership > - The following directories are owned by other packages > required by this package. > ---------------------------------------------------- > /usr/share/scim - by scim > /usr/share/scim/icons - by scim > ---------------------------------------------------- Fixed. > * Timestamps > - This package contains some > * text files (such as "*.sty") > * image files (such as "*.png) > and keeping timestamps on these files are recommended. > Generally, > ---------------------------------------------------- > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" > ---------------------------------------------------- > works (however currently I cannot test this because > mockbuild fails as attached) Fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review