Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xmlrpc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226565 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-04-26 14:37 EST ------- (In reply to comment #3) > (In reply to comment #2) > > > X verify source and patches (md5sum matches upstream, know what the patches > > do) > > - Source0 doesn't exist > Updated link md5sum matches > > > * skim the summary and description for typos, etc. > > * correct buildroot > > - should be: > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > X if %{?dist} is used, it should be in that form (note the ? and % > > locations) > > - Please fix Release tag by adding %{?dist} > Fixed > Great! > Updated SRPM: > https://mwringe.108.redhat.com/files/documents/175/348/xmlrpc-2.0.1-3jpp.3.src.rpm Just built in mock again, everything looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
