Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Empathy - An instant messaging client built using Telepathy Alias: empathy https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241792 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Alias| |empathy ------- Additional Comments From [EMAIL PROTECTED] 2007-05-30 20:58 EST ------- Hi, David. I'd be happy to review this for you. However, someone with proper sponsorship permissions will need to sponsor you into the Account System groups when it is done (if you're not already sponsored). Before I push this through a mock build though, I see some things in the spec file that seem wrong: (1) Your desktop-file-install invocation puts the .desktop file into the autostart directory; meaning that it will be started at every desktop session. It'd be better, I believe, if you install it to the global %{_datadir}/applications directory. In that way, the user can choose to add it to their session startup as normal if they wish. ( (2) Your %files listing makes the package own everything in %{_datadir}/empathy/, but not the directory itself. If you change that to the directory (remove the asterisk), then rpm-build will automagically know to own that directory and everything it contains, recursively. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
