Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: telepathy-glib - glib binding for the Telepathy D-Bus protocol https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242790 ------- Additional Comments From [EMAIL PROTECTED] 2007-06-18 14:25 EST ------- Some rpmlint noise: W: telepathy-glib mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) This is not really a problem; fix it if you like. W: telepathy-glib unused-direct-shlib-dependency /usr/lib64/libtelepathy-glib.so.0.2.0 /lib64/libdbus-1.so.3 My understanding is that this is merely an inefficiency, and not a real one at that because dbus is going to be there in any case. So I don't think it's a blocker. W: telepathy-glib-devel no-documentation W: telepathy-glib-unstable-static no-documentation On their surface these are OK, but t does beg the question of whether %{_datadir}/gtk-doc/html/%{name}/ in the -devel subpackage should be %doc or not. There's a test suite included; I added a simple %check section: %check make check and it seemed to run fine. Any reason not to run it? Regarding the static library issue, I don't think that there's any reason to believe that upstream won't drop the static library as soon as they have a stable API. Review: * source files match upstream: b65afe985035b2fe88aeda82bb012fb9c40babbcd78b0043c03e32a943625014 telepathy-glib-0.5.13.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. ? rpmlint has one questionable issue (%doc for gtk-doc directory) * final provides and requires are sane: telepathy-glib-0.5.13-2.fc8.x86_64.rpm libtelepathy-glib.so.0()(64bit) telepathy-glib = 0.5.13-2.fc8 = /sbin/ldconfig libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libtelepathy-glib.so.0()(64bit) telepathy-glib-devel-0.5.13-2.fc8.x86_64.rpm telepathy-glib-devel = 0.5.13-2.fc8 = dbus-devel dbus-glib-devel libtelepathy-glib.so.0()(64bit) pkgconfig telepathy-filesystem telepathy-glib = 0.5.13-2.fc8 telepathy-glib-unstable-static-0.5.13-2.fc8.x86_64.rpm telepathy-glib-unstable-static = 0.5.13-2.fc8 = pkgconfig telepathy-glib = 0.5.13-2.fc8 telepathy-glib-devel = 0.5.13-2.fc8 X %check is not present, but there seems to be a runnable test suite. * no shared libraries present; ldconfig called as necessary. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (ldconfig) * code, not content. * documentation is in -devel subpackage and isn't excessively large. * %docs are not necessary for the proper functioning of the package. * headers are in -devel (or -static-unstable) package. * pkgconfig files present in -devel or -static* packages; pkgconfig dependency is there. * static library is in -static* package. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
