Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kde-style-domino - KDE style with a soft look https://bugzilla.redhat.com/show_bug.cgi?id=249236 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2007-09-04 14:57 EST ------- I'm taking this review. Can you update the spec in accordance to fedora packaging guidelines ? a quick look : #001 upstream naming convention fedora kde sig hasn't yet formalized the us of kde-style-XXX thus you can drop : -n domino-%{version} from %setup #002 correct License tag #003: >= 3.0.0 be removed from BuildRequires: As FC6 already has a KDE > 3. #004: remove qt-devel from the BuildRequires: As kdelibs-devel already requires qt-devel rpm -qR kdelibs-devel [..] qt-devel [..] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
