Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: vdr-skinsoppalusikka - The "Soppalusikka" skin for VDR https://bugzilla.redhat.com/show_bug.cgi?id=321351 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED ------- Additional Comments From [EMAIL PROTECTED] 2007-10-07 11:19 EST ------- Good work, just some minor remarks: - License should be GPL+, not GPLv2 as the sources or anything in the package doesn't specify a GPL version and in that case (per the GPL text itself, chapter 9 of GPLv2 COPYING) any version of GPL goes. - s/femon/skinsoppalusikka/ in vdr-skinsoppalusikka.conf's comments - The main vdr package already owns the /var/lib/vdr/themes dir, so the %dir entry for it should be removed from %files in this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
