Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: picard - MusicBrainz music file tagger https://bugzilla.redhat.com/show_bug.cgi?id=382101 ------- Additional Comments From [EMAIL PROTECTED] 2007-11-14 09:32 EST ------- Ok here is a full review: * License (GPLv2+) COPYING provided - OK * Checks for License of dependents packages - OK for libdiscid "pre"-review https://bugzilla.redhat.com/382101 * rpmlint is clean on rpm - OK (not checked on installed RPM yet) * Spec is clean - NeedWork (minor) --delete-original --remove-category="Application" \ Might change to the same line for the "\" * Timestamp - NeedWork (minor) It is desirable to prevent timestamp changes: - when you download source, uses "wget -N "to prevent timestamp change of the source tarball. - When you move files please prevent timestamp to change by using install -pm 0644 $RPM_BUILD_ROOT%{_datadir}/icons/picard-*.png $RPM_BUILD_ROOT%{_datadir}/pixmaps/ then remove old directory with : rm -rf $RPM_BUILD_ROOT%{_datadir}/icons * Package is built with $RPM_OPT_FLAGS - OK * Debuginfos are extracted - OK extracting debug info from /var/tmp/picard-0.9.0-0.2.beta1.fc9-root-kojibuilder/usr/lib64/python2.5/site-packages/picard/util/astrcmp.so extracting debug info from /var/tmp/picard-0.9.0-0.2.beta1.fc9-root-kojibuilder/usr/lib64/python2.5/site-packages/picard/musicdns/ofa.so 13 blocks * Runtime test - Not tested yet.. See if we could have libdiscid reviewed and imported first. I've asked on the bug if someone what to submit it for review but as there is already a spec attached I think you could also propose to take it... The issues with timestamp are minors, but they are also easy to fix, so please consider adding support for libdiscid first then update the new picard src.rpm with fixed timestamp. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
