Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libogg https://bugzilla.redhat.com/show_bug.cgi?id=226035 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-11-14 10:30 EST ------- To all interested reviewers, I've become a libogg co-maitainer recently and I would like to push libogg through its merge review. (In reply to comment #1) > Must Fix: > * The devel package require should be: > Requires: libogg = %{epoch}:%{version}-%{release} Already fixed in current rawhide version. > * Is the static lib necessary? Already removed in the current rawhide version. > Minor: > * Doesn't use preferred buildroot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > * Drop the '.' from the summary to quite rpmlint. > * To clean out the install & clean section, you should probably use 'rm -rf > $RPM_BUILD_ROOT' for consistancy All 3 already fixed in the current rawhide version. > * Does this package build using 'make %{_smp_mflags}'? Just added it to CVS, should show up in rawhide soon. (In reply to comment #8) > It's pretty much the same issue as pkgconfig files; you can't own the > directory > they go in, so you must have a dependency on the package that does. Requires: automake already present in current rawhide -devel package --- So all is fixed now, please review and tell me what needs fixing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
