Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xchat-ruby - X-Chat plugin adding Ruby scripting functionality https://bugzilla.redhat.com/show_bug.cgi?id=389151 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2007-11-28 08:57 EST ------- For 1.2-4: * SourceURL - I suggest to use http://downloads.sourceforge.net/xchat-ruby/%{name}-%{version}-src.tar.gz With this, you don't have to rewrite sourceURL when new version is released. * Ruby API dependency for BuildRequires - While this is not written in ruby guidelines, I usually recommend to add also ------------------------------------------------------ BuildRequires: ruby(abi) = 1.8 ------------------------------------------------------ for the consistency with Requires. * Macros in %changelog ------------------------------------------------------ * Fri Nov 23 2007 Conrad Meyer <[EMAIL PROTECTED]> - 1.2-2 - Replaced /etc with %{_sysconfdir} ------------------------------------------------------ - Perhaps $ rpm -q --changelog xchat-ruby will show ------------------------------------------------------ * Fri Nov 23 2007 Conrad Meyer <[EMAIL PROTECTED]> - 1.2-2 - Replaced /etc with /etc ------------------------------------------------------ This is because macros are expanded even in %changelog. To avoild this, please use %% in changelog. i.e. ------------------------------------------------------ * Fri Nov 23 2007 Conrad Meyer <[EMAIL PROTECTED]> - 1.2-2 - Replaced /etc with %%{_sysconfdir} ------------------------------------------------------ Well, as this is SPONSORNEEDED ticket, ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
