Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cairo-clock - Cairo-rendered on-screen clock https://bugzilla.redhat.com/show_bug.cgi?id=398601 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2007-12-19 17:35 EST ------- Benoît, sounds like you have not yet been sponsored for cvs-extras. Please visit : https://admin.fedoraproject.org/accounts/userbox.cgi?_edit=1 Add yourself as under the groupname "cvsextras", so as I can approve you. Once you are done, you'll need to wait till I'll grant you the access :) #001: please apply the required timestamps: instead of : make install DESTDIR=%{buildroot} use: %{__make} INSTALL="install -p" DESTDIR=$RPM_BUILD_ROOT during the %{__make} install process there needs to be a "-p" in this /usr/bin/install -c -m 644 'clock-face.svg' '.... #002: please use the same email address as that of your "fedora account" in the %changelog #003: are these requires realy needed ?? Avoid the use of versions in Requires as far as you can Requires: perl-XML-Parser Requires: libglade2 >= 2.6.0 Requires: librsvg2 >= 2.14.0 #004: drop INSTALL from %doc, because the user doesn't need that file since it's your job to compile the package :) #005 --vendor Fedora please rename it to --vendor fedora (small f) ls /usr/share/applications/ | grep fedora you will see that most are starts with "f". All these are not blockers, but it helps others to quickily understandy tour spec and help you eventually. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
