Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mt-daapd - An iTunes-compatible media server https://bugzilla.redhat.com/show_bug.cgi?id=248277 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2007-12-24 05:55 EST ------- source files match upstream package meets naming and versioning guidelines specfile is properly named, is cleanly written and uses macros consistently dist tag is present the package must meet the Packaging Guidelines build root is correct: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) license field matches the actual license license is open source-compatible. GPL included in package. (COPYING) latest version is being packaged BuildRequires are proper compiler flags are appropriate %clean is present package builds in mock ( ) package installs properly debuginfo package looks complete rpmlint is silent. NO, but the error is intended. OK E: non-readable /etc/mt-daapd.conf 0640 final provides and requires are sane %check is present and all tests pass: Not applicable no shared libraries are added to the regular linker search paths. owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. file permissions are appropriate. scriptlets present OK code, not content. documentation is small, so no -docs subpackage is necessary. %docs are not necessary for the proper functioning of the package. no headers. no pkgconfig files. no libtool .la droppings. not a GUI app. The INSTALL file in %doc contains generic installation instructions and it's not needed, you may consider remove it. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
