Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pic2aa - Pic2AA is tool providing converting jpeg/png to AA (Ascii Art) images https://bugzilla.redhat.com/show_bug.cgi?id=432246 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2008-02-10 13:52 EST ------- I'm not sponsored so I can't approve this, but from what I can see it meets every requirement. The only changes I would make are that the word 'providing' should be replaced with 'for' in the summary and description, and 'preview' should be 'previews', also in the description. Source file match upstream: YES Package meets versioning and naming guidelines: YES Specfile is properly named, is cleanly written and uses macros consistently: YES Dist tag is present: YES Build root is correct: YES License field matches the actual license: YES License is open source-compatible: YES Latest version is being packaged: YES BuildRequires are proper: YES Compiler flags are appropriate: YES %clean is present: YES Package installs properly debuginfo package looks complete: YES rpmlint is silent: YES Final provides and requires are sane: YES %check is present and all tests pass: YES No shared libraries are added to the regular linker search paths: YES Owns the directories it creates: YES Doesn't own any directories it shouldn't: YES No duplicates in %files: YES File permissions are appropriate: YES No scriptlets present: YES Code, not content: YES Documentation is small, so no -docs subpackage is necessary: YES No headers: YES No pkgconfig files: YES No libtool .la droppings: YES -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
