Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: glpi-mass-ocs-import - GLPI Plugin for OCS Massive import https://bugzilla.redhat.com/show_bug.cgi?id=426567 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From [EMAIL PROTECTED] 2008-02-16 02:21 EST ------- Review: + package builds in mock. + rpmlint is silent for SRPM. + rpmlint warnings for RPM should be safely ignored + source file are ok. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + BuildRequires are proper. + package installed properly. + Macro use appears rather consistent. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
