Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fsvs - full system versioning using subversion repositories https://bugzilla.redhat.com/show_bug.cgi?id=433778 ------- Additional Comments From [EMAIL PROTECTED] 2008-03-26 09:14 EST ------- (In reply to comment #16) > I have one cosmetic suggestion for this package: if you do not mind, please > move > the three "%defines" from %install to the top of the package. Makes life > easier > for people examining the spec, most people do not expect to find "%defines" in > the middle of the spec. Done > Not to mention that you could ditch them completely, all files from "%doc_dir" > (and the directory itself) could be included with a single %doc directive and > the other two defines are used only twice each. Oh OK, Done that instead :-) Spec URL: http://davidf.sjsoft.com/fedora/fsvs.spec SRPM URL: http://davidf.sjsoft.com/fedora/fsvs-1.1.13-4.fc8.src.rpm i386 RPM URL: http://davidf.sjsoft.com/fedora/fsvs-1.1.13-4.fc8.i386.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
