Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: trickle - Portable lightweight userspace bandwidth shaper https://bugzilla.redhat.com/show_bug.cgi?id=450408 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From [EMAIL PROTECTED] 2008-06-15 09:46 EST ------- Well, for 1.07-1: * License - Many codes are licensed under 4 clause BSD, so the license tag must be "BSD with advertising". * Parallel make - Please write a note on the spec file that this package is parallel make unsafe. * ldconfig - Calling /sbin/ldconfig on scriptlets are not needer for this package. trickle-overload.so is not under default library search paths, and it is only dlopen'ed. * 64 bit issue - (Although I have 32 bit machine only) I guess this package doesn't work on 64 bit machine. +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure: ---------------------------------------------------- 21008 clibdir="$prefix/lib/trickle" 21009 21010 cat >>confdefs.h <<_ACEOF 21011 #define SYSCONFDIR "$csysconfdir" 21012 _ACEOF 21013 21014 cat >>confdefs.h <<_ACEOF 21015 #define LIBDIR "$clibdir" 21016 _ACEOF ---------------------------------------------------- trickle.c: ---------------------------------------------------- 40 #define LIBNAME "trickle-overload.so" 51 char *trypaths[] = { 52 LIBNAME, 53 LIBDIR "/" LIBNAME, 54 NULL 55 }; 103 for (pathp = trypaths; *pathp != NULL; pathp++) 104 if (lstat(*pathp, &sb) == 0) 105 break; 106 107 path = *pathp; 108 if (path == NULL) 109 errx(1, "Could not find overload object"); ---------------------------------------------------- trickle.spec: ---------------------------------------------------- 59 %{_bindir}/trickled 60 %{_libdir}/%{name}/trickle-overload.so 61 %{_mandir}/man1/%{name}.1.gz ---------------------------------------------------- On 64 bit machine, %_libdir is /usr/lib64. +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
