Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocp - Open Cubic Player for MOD/S3M/XM/IT/SID/MIDI music files https://bugzilla.redhat.com/show_bug.cgi?id=452749 ------- Additional Comments From [EMAIL PROTECTED] 2008-06-24 21:13 EST ------- Thanks. I've applied most of your suggested changes. New packages here: Spec URL: http://cra.fedorapeople.org/ocp/ocp.spec SRPM URL: http://cra.fedorapeople.org/ocp/ocp-0.1.15-2.fc9.src.rpm Koji scratch builds: f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=679020 f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=679039 I've sent all patches upstream already. I'll let upstream decide how to best apply them and then I'll remove them from the package. I'm told that the libid3tag requirement is going away upstream, but I reenabled it anyway. Not sure it gets used without libmad being built... Bumped release to 2 and will use only integers from now on. I did try building x86_64 locally, and while it builds, there are issues with popping/clipping and incorrect playback. I've reenabled all archs for now and will work with upstream as issues arise. Regarding desktop-file-install, I'm renaming the file to meet the letter of this guideline: MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. This is described in detail in the [wiki:Self:Packaging/Guidelines#desktop desktop files section of Packaging Guidelines] . If you feel that using opencubicplayer.desktop rather than changing it to be ocp.desktop is acceptable, I'll take out the rename. It doesn't matter to me either way... Thanks again for taking a look at this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
