Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #25 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-12 12:17:34 EDT --- For 1.2.3-1: * Requires(preun) https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets - %preun uses /sbin/service and "Requires(preun): initscripts" is needed ! %postun - Would you consider to add %postun section as described in https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets (If there is a reason adding this %postun must be avoided, it is no problem) * cflags/install flags - build.log shows --------------------------------------------------------- 201 make[1]: Leaving directory `/builddir/build/BUILD/pgbouncer-1.2.3/doc' 202 gcc -c -o lib/client.o src/client.c -DHAVE_CONFIG_H -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wmissing-prototypes -Wpointer-arith -Wendif-labels -Wdeclaration-after-statement -Wold-style-definition -Wstrict-prototypes -Wundef -Wformat -Wnonnull -Wstrict-overflow -fomit-frame-pointer -I./include -I./include 269 mkdir -p /builddir/build/BUILDROOT/pgbouncer-1.2.3-1.fc10.i386/usr/share/doc/pgbouncer 270 install -s -m 755 ./pgbouncer /builddir/build/BUILDROOT/pgbouncer-1.2.3-1.fc10.i386/usr/bin --------------------------------------------------------- -- -fomit-frame-pointer makes debugging very difficult -- "install -s" removes debugging information and makes failure of debuginfo rpm So both are forbidden on Fedora. For this package the following can fix these issues: --------------------------------------------------------- sed -i.fedora \ -e 's|-fomit-frame-pointer||' \ -e '/BININSTALL/s|-s||' \ configure --------------------------------------------------------- * Timestamps - When installing files by "cp" or "install", add "-p" option to keep timestamps on them. * Permission --------------------------------------------------------- pgbouncer.src: W: strange-permission pgbouncer.init 0775 pgbouncer.i386: E: executable-marked-as-config-file /etc/sysconfig/pgbouncer pgbouncer.i386: E: script-without-shebang /etc/sysconfig/pgbouncer --------------------------------------------------------- - All files in the srpm must have 0644 permission. - %_sysconfdir/sysconfig/pgbouncer must have 0644 permission. * %config --------------------------------------------------------- pgbouncer.i386: W: conffile-without-noreplace-flag /etc/sysconfig/pgbouncer --------------------------------------------------------- - Would you explain why you don't want to use %config(noreplace) %{_sysconfdir}/sysconfig/%{name}? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
