Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461007 --- Comment #6 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-09-26 04:00:42 EDT --- Review: NA = Not applicable, ! = requires attention, x = passed Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=845010 source from project resource: md5sum libftdi-0.14.tar.gz 43f20478e725aa5ba6cdae311ca0593d libftdi-0.14.tar.gz source from srpm: md5sum libftdi-0.14.tar.gz 43f20478e725aa5ba6cdae311ca0593d libftdi/libftdi-0.14.tar.gz RPMLINT: CLEAN [EMAIL PROTECTED] SRPMS]$ rpmlint libftdi-0.14-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [EMAIL PROTECTED] i386]$ rpmlint libftdi-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [EMAIL PROTECTED] i386]$ rpmlint libftdi-devel-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [EMAIL PROTECTED] i386]$ rpmlint libftdi-0.14-1.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Required: [x] package name [x] package base name and spec name - same [x] packaging guidelines [x] license file included [x] license correct [x] spec legible & in American english [x] md5sum checked source [x] package compiled on all primary architectures [x] Buildrequires tag - okay [NA] locale [NA] desktop file - GUI [x] shared library - ldconfig called in %post and %postun [x] owns all directories it creates [x] permissions in %defattr correct [x] %clean and %install section have 'rm -rf $RPM_BUILD_ROOT' [x] %doc files don't have any dependency on other section of package [!] Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). You should remove pkgconfig from BuildRequires and put it in Requires Moreover in devel package requires Requires: %{name} = %{version}-%{release} is enough [x] valid encoding Optional: [x] description and summary fine [NA] license file query [x] package functioning - okay [NA] any scripts [x] no dependencies outside FHS guideline paths [x] .pc file in devel pkg Summary: other then one point mentioned in [!] above - everything looks okay -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
