Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462818 Paul Howarth <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Paul Howarth <[EMAIL PROTECTED]> 2008-10-14 05:25:04 EDT --- OK, that looks fine. A couple of minor comments: 1. Please bump the release number of the package every time you make a change that anyone else (e.g. a reviewer) will see; this removes a possible source of confusion about which version of a package any particular comment applies to, and once you're building packages in Fedora, will ensure that packages you build and subsequently release are consistent with any that people may build locally from CVS. 2. I find it aids readability to append a "/" to directories included in %files lists, just to emphasize that they are directories (which in many cases will include further files, though that's not the case here), e.g. dir %{perl_vendorlib}/Net/ APPROVED. Let me know your account name in the Fedora Account System and I'll sponsor you for membership of the Fedora Packager CVS Commit Group. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
