Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225798 --- Comment #4 from Orcan 'oget' Ogetbil <orcanba...@yahoo.com> 2008-12-11 15:17:18 EDT --- Thanks for the update. There are two more little things: * From the SPEC file: cat << EOF > files.list %%defattr (-, root, root, -) %%dir %{_datadir}/gimp/%{gimpsubver}/help %{_datadir}/gimp/%{gimpsubver}/help/images EOF and echo "%%lang($dir) %{_datadir}/gimp/%{gimpsubver}/help/$dir" >> "$f" The macro entries with single % expand into the files.list . This is equivalent to putting hard-coded paths into %files . I think those macro entries need double-% too. * Parallel make must be supported whenever possible (If it is not supported, this should be noted in the SPEC file as a comment.). Sorry that I missed this in my initial review. Enabling the parallel make didn't cause a problem with my dual core. It certainly speeds things up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
