Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473477


Lubomir Rintel <lkund...@v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nob...@fedoraproject.org    |lkund...@v3.sk
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Lubomir Rintel <lkund...@v3.sk>  2008-12-29 08:21:03 EDT ---
Good Work.

* filelists fine
* provides/requires sane
* rpmlint silent
* builds in mock
* license ok, text included in %doc
* seems to run fine

Just a few notes, definitely not blockers:

1.) Please set vendor to "fedora" in the desktop entry
https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation

2.) The description seems completely irrelevant to me
I'd expect it to tell me what's in the package (the client), not the
description of framework architecture. Please reconsider it.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to