Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468462 --- Comment #6 from Simon Wesp <cassmod...@fedoraproject.org> 2009-01-05 11:46:18 EDT --- > Issues: > - Timestamp of Source0 does not match, see > https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps I downloaded it again. Now it should be right > - Desktop files: > - paths are hardcoded > - key "Categories" is a list and does not have a semicolon as trailing > character > - Categories are IMO not correct. Suggestion: > sbackup-restore = System;Utility;Filesystem;Archiving;GNOME;GTK; > sbackup-conf = System;Settings;SystemSettings;GNOME;GTK; > In case of doubt see > http://standards.freedesktop.org/menu-spec/latest/apa.html > - add GenericNames for KDE compatibility. Use the window title > Restore files/directories, Backup Properties > - please add (at least German) Translations for the keys, e. g. > GenericName[de]=Dateien/Verzeichnisse wiederherstellen Should now meet your requirements > - Requires: usermode-gtk for the password dialog rpmlint says "sbackup.noarch: W: no-dependency-on usermode" should be okay because usermode-gtk requires usermode > - Use global pam config? > #%PAM-1.0 > auth include config-util > account include config-util > session include config-util Okay, i changed it. > - I suggest you include pam config as separate sources instead of creating > them > on the fly. I think creating them on the fly is very beautiful, because there are no hardcoded paths > - include an initscript for sbackupd? not relevant, because sbackupd will be controled by a crontab, created by simple backup config > - What are the Exclude statements for? https://fedoraproject.org/wiki/Packaging/Python#Unnecessary_Byte_compilation SPEC: http://cassmodiah.fedorapeople.org/sbackup-0.10.5/sbackup.spec SRPM: http://cassmodiah.fedorapeople.org/sbackup-0.10.5/sbackup-0.10.5-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
