Tom Moertel wrote:
I packaged plyr tonight:
http://community.moertel.com/rpms/fedora/10/SPECS/R-plyr.spec
Thanks for taking a stab at plyr. I'm a very inexperienced packager, but
these are the questions that I'd be asking if I were a reviewer.
- Do you need to worry about the requires (R-RUnit R-abind R-tcltk)?
- It seems wrong to hard-code Source0 rather than making it conditional
on the variables defined in the spec. See my RMySQL spec (which could be
totally goofy, and I've had no feedback on it) here:
https://www.redhat.com/archives/fedora-r-devel-list/2009-August/msg00007.html
- Since plyr is noarch, you could remove the commented-out arch-specific
stuff.
_______________________________________________
Fedora-r-devel-list mailing list
Fedora-r-devel-list@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-r-devel-list
