Alex Karasulu wrote:
Richard S. Hall wrote:
After looking closer at the patch I notice a couple of issues:
1. Does it make sense to set the thread as a daemon? I don't think
frameworks are required to have non-daemon threads...we would have
to think about it.
Personally I don't understand why there is another thread? What's the
point to it? Can't you just detect that stdin is not valid and just
handle things in the same thread?
I think there is just one thread.
Anyway, I initially wrote this patch (sometime ago) when testing
ShellTUI against Oscar 1.0.2, in situations where I wanted Oscar to
*NOT* run interactivelly. IIRC, the daemon flag is required if:
- the framework is started in the background
- the framework is shutdown not from ShellTUI (e.g. telnet)
Then the ShellTUI thread is stuck in the in.readLine() call and the
framework never ends. I'm not sure if this applies to felix.
2. Bundles are not supposed to call stop on themselves, so we would
have to change that...we don't really need to stop the bundle, we
can just have it stop processing input.
+1 to this ... that's the core problem.
I'm sure I saw this on other bunldes, so please explain: how should a
bundle stop itself if required ?
Nevertheless,
+1
Alex
--
nek
