[ http://issues.apache.org/jira/browse/FELIX-50?page=comments#action_12423581 ] Marcel Offermans commented on FELIX-50: ---------------------------------------
I think it's a good idea to split these changes, and I would like to have some discussions on the list on how to proceed with certain changes (so anybody reading this, please provide feedback). The bugfixes are simple, they should be included. I did the one for the null object proxy, but are there others? The configuration dependencies need to be added. Regarding the current implementation I have one issue, and that is the "Configuration" class you use to wrap the dictionary object that is used. I can imagine that you want to use such a "helper class" to do certain things, but I am a bit reluctant to include this by default. Then there is a refactoring where you renamed Service and ServiceImpl to DependentServiceController (and Impl). Personally, I would like to keep the original names. About asynchronously starting for bundles with long running start methods, you now spawn a new thread and use that to call activateServiceInternal() which does many things, including invoking "init" and "start" methods. My main concern here is that I don't think this is a problem that should be solved by the dependency manager. If your service implementation does lengthy operations in its "init" or "start" methods, it should spawn a background thread there (this is in my opinion similar to the way the OSGi spec deals with this in the "start" of the bundle activator). About the command for the felix console, I think it's a good idea to create some kind of monitoring facility for the dependency manager. Ideally I would like to keep this as an extra plugin as much as possible, although I realize that we will probably need some API to access this information. To be honest I need to take a closer look at how you have done this now, and I would like to review if this would also be useful when used together with our new JMX implementations (to create some kind of MBean that shows these dependencies). So my proposal would be that I start implementing any remaining bugfixes as well as the configuration dependency (without that Configuration wrapper). The other features need some more discussion first. > Some contribution to the Dependency manager > ------------------------------------------- > > Key: FELIX-50 > URL: http://issues.apache.org/jira/browse/FELIX-50 > Project: Felix > Issue Type: Improvement > Components: Dependency Manager > Reporter: Peter Neubauer > Assigned To: Marcel Offermans > Attachments: com.scancoin.core.servicemonitor.tar, > com.scancoin.core.servicemonitor.zip, com.scancoin.core.servicemonitor.zip, > com.xenotron.osgi.tar, com.xenotron.osgi.zip > > > These are some contributions regarding the new Felx Dependency Manager -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
