[ http://issues.apache.org/jira/browse/FELIX-26?page=comments#action_12431959 ] Richard S. Hall commented on FELIX-26: --------------------------------------
As a result of looking into this patch, I realized that there are a couple of other issues that need to be addressed. First, the patch (and the existing code) only checks for library matches at execution time, but the spec also indicates that some native library checks must be performed at installation time. This means that a bit of this stuff has to be moved around so that it can be performed earlier, perhaps as part of ManifestParser. Second, the way we are currently parsing the library header is incorrect, since we break up a header with multiple libraries into separate clauses (essentially we factor the properties across the library files), which is not correct with respect to the spec. Each clause (with potentially multiple libraries) should stay as a single clause and the algorithm should select just one clause and that clause will be used to determine all of the native libraries available for the bundle on that platform. I am looking into resolving both of these issues and modifying the patch as well as the exist code to comply. > Improve native library matching algorithm > ----------------------------------------- > > Key: FELIX-26 > URL: http://issues.apache.org/jira/browse/FELIX-26 > Project: Felix > Issue Type: Improvement > Components: Specification compliance, Framework > Reporter: Richard S. Hall > Assigned To: Richard S. Hall > Attachments: 2006-08-29_FELIX-26_patch.zip, > 2006-08-29_FELIX-26_patch2.zip, 2006-08-30_FELIX-26_patch3.zip > > > This issue is described in section 3.9 of the OSGi R4 specification. R4 has > improved and made the native library matching alogirithm; this is invoked > when a bundle's class loader is asked for the native library when a class in > the bundle has a native method. The current Felix implementation is a > simplified version of the OSGi R3 algorithm. This change should be localized > to the org.apache.felix.framework.OSGiLibrarySource class. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
